D12388: Output device color curves correction

David Edmundson noreply at phabricator.kde.org
Tue May 1 19:02:51 UTC 2018


davidedmundson added a comment.


  Looks pretty good. +1

INLINE COMMENTS

> outputdevice.cpp:323
> +        uint16_t *curvePtr = reinterpret_cast<uint16_t *>(curve->data);
> +        for (size_t i = 0; i < curve->size / sizeof(uint16_t); i++) {
> +            destination->append(curvePtr[i]);

You can do this all in once

destination->resize(curve->size);
memcpy(...)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks
Cc: davidedmundson, zzag, cfeck, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180501/3e0db5d4/attachment.html>


More information about the Kde-frameworks-devel mailing list