D11734: Have KIO build for Android

[Albert Astals Cid]

aacid added a comment.


  In D11734#236186 <https://phabricator.kde.org/D11734#236186>, @apol wrote:
  
  > In D11734#235886 <https://phabricator.kde.org/D11734#235886>, @aacid wrote:
  >
  > > Would it make sense do document the classes/methods that won't work in Android?
  >
  >
  > I was about to do that, but I feel a bit weird because it's as if the rest would work, which I cannot ensure.
  
  
  Right
  
  > PreviewJob will work, just without the shared memory, which in Android doesn't really matter.
  > 
  >   diff --git a/src/core/kmountpoint.h b/src/core/kmountpoint.h
  >   index 1762ae8d..ef7bd8cc 100644
  >   --- a/src/core/kmountpoint.h
  >   +++ b/src/core/kmountpoint.h
  >   @@ -83,6 +83,8 @@ public:
  >         * This function gives a list of all currently used mountpoints. (mtab)
  >         * @param infoNeeded Flags that specify which additional information
  >         * should be fetched.
  >   +     *
  >   +     * @note this method is not supported on Android
  
  supported -> implemented? or "@note this method returns an empty list on Androd" ? I'd like to introduce some "if you want to help let's fix it", but probably a bit too long for a @note ?
  
  >    */
  >   static List currentMountPoints(DetailsNeededFlags infoNeeded = BasicInfoNeeded);
  >     
  > 
  >

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11734

To: apol, #frameworks
Cc: aacid, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180331/bf8564fc/attachment.html>