D11740: ktooltipwidget: Subtract margins from available size
Elvis Angelaccio
noreply at phabricator.kde.org
Thu Mar 29 20:17:51 UTC 2018
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ktooltipwidgettest.cpp:33-37
> +void initStyle() {
> + // Change manually to test available styles
> + // QApplication::setStyle(QStringLiteral("Windows"));
> +}
> +Q_CONSTRUCTOR_FUNCTION(initStyle)
This is not needed, it is possible to just use the standard style switch: `ktooltipwidgettest -style windows`
> ktooltipwidget.cpp:183
> d->addWidget(content);
> + auto marginSize = QSize{
> + 2 * content->style()->pixelMetric(QStyle::PM_DefaultTopLevelMargin),
`const`
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D11740
To: michaelh, #frameworks, elvisangelaccio
Cc: elvisangelaccio, cfeck, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180329/6a7f9a87/attachment.html>
More information about the Kde-frameworks-devel
mailing list