D11768: Add Desktop and Downloads to the default list of Places

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> kfileplacesmodel.cpp:245
> +                                              QStringLiteral("Desktop"), I18N_NOOP2("KFile System Bookmarks", "Desktop"),
> +                                              QUrl::fromLocalFile(QStandardPaths::writableLocation(QStandardPaths::DesktopLocation)), QStringLiteral("user-desktop"));
> +

Desktop KIO claims that this may return $HOME if the Desktop folder does not exist, can you confirm/invalidate that?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg
Cc: broulik, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180329/432ebb68/attachment.html>