D11529: Balooctl: Deindex unfound files with check command.

James Smith noreply at phabricator.kde.org
Wed Mar 28 18:46:52 UTC 2018


smithjd added inline comments.

INLINE COMMENTS

> broulik wrote in fileindexerconfig.cpp:63
> Please create the `StorageDevices` object on demand, otherwise this penalizes all users of that class that just want to know whether Baloo itself is enabled, which was the main reason for doing D11279 <https://phabricator.kde.org/D11279>

I had presumed that the optimization came from re-using the already existing cache instead of recreating it, rather than creating the SolidDevices object on demand.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11529

To: smithjd, #baloo, vhanda, michaelh, broulik
Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180328/412e1cad/attachment.html>


More information about the Kde-frameworks-devel mailing list