D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

David Faure noreply at phabricator.kde.org
Mon Mar 26 19:08:54 UTC 2018


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> file_unix.cpp:416
>  
> -#ifdef Q_OS_LINUX
> +#ifdef HAVE_SYS_XATTR_H
>  static bool isNtfsHidden(const QString &filename)

should be #if, not #ifdef.

It's always defined, to either 0 or 1.

> file_unix.cpp:550
>              if (createUDSEntry(filename, QByteArray(ep->d_name), entry, details)) {
> -#ifdef Q_OS_LINUX
> +#ifdef HAVE_SYS_XATTR_H
>                  if (isNtfsHidden(filename)) {

same

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11716

To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180326/f78ea051/attachment.html>


More information about the Kde-frameworks-devel mailing list