D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Mon Mar 26 13:41:41 UTC 2018
kossebau added inline comments.
INLINE COMMENTS
> config-kioslave-file.h.cmake:14
> +/* Defined if system has extended file attributes support. */
> +#cmakedefine01 HAVE_SYS_XATTR_H
While FindACL.cmake sets internally the cmake variable HAVE_SYS_XATTR_H, it is not part of the officially set variables (cmp. notes in header of that file)
So more future-proof will be to do an explicit
check_include_files(sys/xattr.h HAVE_SYS_XATTR_H)
in src/ioslaves/file/CMakeLists.txt instead of reyling on an undocumented side-effect of `find_package(ACL)`.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11716
To: rominf, #dolphin, kossebau, dfaure
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180326/7f08b738/attachment.html>
More information about the Kde-frameworks-devel
mailing list