D11183: Sonnet: don't impose the default client

Milian Wolff noreply at phabricator.kde.org
Mon Mar 26 12:16:42 UTC 2018


mwolff added inline comments.

INLINE COMMENTS

> loader.cpp:103
> +        // if it does it will be an element of lClients.
> +        bool unknown = std::find_if(lClients.constBegin(), lClients.constEnd(), [backend] (const Client *client) {
> +                return client->name() == backend; }) == lClients.constEnd();

nope, that's wrong. find_if returns an iterator - in this case a Client* probably that gets converted to bool?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: mwolff, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180326/285e10d9/attachment.html>


More information about the Kde-frameworks-devel mailing list