D11529: Balooctl: Deindex unfound files with check command.

James Smith noreply at phabricator.kde.org
Sun Mar 25 23:57:15 UTC 2018


smithjd added inline comments.

INLINE COMMENTS

> michaelh wrote in fileindexscheduler.h:83
> Nitpick: We're removing db entries not files. Also every file is deindexable. Maybe 'purgeStaleEntries', 'removeLostEntries' or so would be a better name to describe what's going on.

This is doing the opposite of indexing new files, which is removing unfound files from the index. I think deindex is an appropriate term for this.

> michaelh wrote in main.cpp:85
> Something like "Update the index. Remove stale entries and add new files." would describe the actions taken more clearly.

This is probably already clear enough. check isn't designed to be used all that often; it's already run at kde startup.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11529

To: smithjd, #baloo, vhanda, michaelh
Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180325/57124156/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list