D11365: also test for value types in taglibextractortest and fix errors

Alexander Stippich noreply at phabricator.kde.org
Sun Mar 25 17:53:58 UTC 2018


astippich added a comment.


  It's just testing each file for all available properties, one after another. This revision just adds missing bits to the existing test. Refactoring should be done separately imho

INLINE COMMENTS

> michaelh wrote in propertyinfo.cpp:98
> Looks unrelated to me.

It's not, composer should really be treated the same as e.g. artist or lyricist, as it can have multiple entries.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D11365

To: astippich, #frameworks, #baloo, mgallien, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180325/5734c103/attachment.html>


More information about the Kde-frameworks-devel mailing list