D11685: Implement single click on line number to select line of text

[Randy Kron]

rkron created this revision.
rkron added reviewers: Frameworks, Kate, KTextEditor, ngraham.
Restricted Application added projects: Kate, Frameworks.
rkron requested review of this revision.

REVISION SUMMARY
  Implements selecting entire line of text with a single click on line number.
  
  Introduce a new config setting on the 'Text Navigation' editor config page
  to enable this, disabled by default to retain old behavior.
  
  Also fixes inconsistancy when dragging on line numbers to select multiple
  lines. When dragging in text editor, view would scroll down when you get
  to the top, but view did not scroll when dragging on line numbers.
  
  FEATURE: 372503

TEST PLAN
  With option enabled, check that single click on line number selects line
  the save way that triple-clicking does by default. Check that dragging
  over line numbers selects multiple lines and view scrolls down when
  you get to the top. Check that selecting a line and then Shift+Click
  another line selects all intervening lines. Check that the single click
  behavior can be turned off with the config setting.

REPOSITORY
  R39 KTextEditor

BRANCH
  Bug372503 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11685

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/navigationconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: rkron, #frameworks, #kate, #ktexteditor, ngraham
Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180325/18cffcc6/attachment-0001.html>