D11642: Fix the rcc binary package generation

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Mar 25 02:21:49 UTC 2018


kossebau added inline comments.

INLINE COMMENTS

> KF5PackageMacros.cmake:164
> +                      DEPENDS ${GENERATED_RCC_CONTENTS} ${component}-${root}-metadata-json ${kpkgqrc})
> +    install(FILES ${GENERATED_RCC_CONTENTS} DESTINATION ${KDE_INSTALL_FULL_DATADIR}/${install_dir}/${root}/${component}/ RENAME contents.rcc)
>  

Does a plain `${KDE_INSTALL_DATADIR}` not also work? The non-FULL variable variants are the ones used usually with `install()`. Not exactly sure why they are, but doing here as well would be consistent at least and less surprising.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11642

To: bshah, mart, davidedmundson, apol
Cc: kossebau, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180325/f91eaeca/attachment.html>


More information about the Kde-frameworks-devel mailing list