D11183: Sonnet: don't impose the default client

David Faure noreply at phabricator.kde.org
Sat Mar 24 19:22:47 UTC 2018


dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I like the idea.

INLINE COMMENTS

> loader.cpp:101
> +        // if it does it will be contained in lClients.
> +        QVectorIterator<Client *> itr1(lClients);
> +        bool unknown = true;

a std::find_if would do the same in much fewer lines

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D11183

To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180324/73f1683c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list