D11642: Fix the rcc binary package generation

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in KF5PackageMacros.cmake:158
> This "Generating xyz" might be still good to have. Please consider picking this up with a
> 
>   COMMENT "Generating: ${xyz}"
> 
> added to `add_custom_command`, where ${xyz} gets a proper variable name :) and as content the relative path to the current bin dir, by some
> 
>   file(RELATIVE_PATH xyz ${CMAKE_CURRENT_BINARY_DIR} ${GENERATED_RRC_CONTENTS})
> 
> or possibly using directly without the xyz var `${component}-contents.rcc` in the COMMENT message.

And rather

  COMMENT "Generating ${xyz}"

so without the ":" to follow the usual pattern.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11642

To: bshah, mart, davidedmundson, apol
Cc: kossebau, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180324/ab6745ed/attachment-0001.html>