D11642: Fix the rcc binary package generation

Bhushan Shah noreply at phabricator.kde.org
Sat Mar 24 12:17:50 UTC 2018


bshah created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
bshah requested review of this revision.

REVISION SUMMARY
  kpackage_install_bundled_package used install(CODE ..) for the
  generation and installation of the rcc file. This had multiple flows,
  
  - It didn't respect the DESTDIR variable of install target which made
  
  most of distribution packaging fail as it tried to write to installation
  prefix directly.
  
  - It used the execute_process which resulted in the rcc file generation
  
  at time of install instead of the build-time, so it would fail with
  permission errors if make install is run as normal user

TEST PLAN
  - tested with kdeplasma-addons that it installs all the applets
  - it installs the content.rrc in $prefix/share/plasma/plasmoids/$id/

REPOSITORY
  R290 KPackage

BRANCH
  fix-bundled-packages

REVISION DETAIL
  https://phabricator.kde.org/D11642

AFFECTED FILES
  KF5PackageMacros.cmake

To: bshah
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180324/179ff0fc/attachment.html>


More information about the Kde-frameworks-devel mailing list