D11487: optimization of TextLineData::attribute

[Jaime Torres Amate]

jtamate added a comment.


  In D11487#232497 <https://phabricator.kde.org/D11487#232497>, @mwolff wrote:
  
  > @jtamate I just checked, the function is called with the same parameters for me locally. What output do you get for this:
  >
  > For me this is the interesting bit:
  >
  >   15.097 debug: unknown[unknown:0]: [ (0, 0)  ->  (0, 358720) ] "" true false
  >   15.097 debug: unknown[unknown:0]: 0 1979 358720
  >   23.013 debug: unknown[unknown:0]: [ (5, 0)  ->  (5, 162682) ] "" true false
  >   23.013 debug: unknown[unknown:0]: 5 12 162682
  >   
  
  
  
  
  > So for line 0 I should actually get quite abysmal performance too, worst case 1979 * 358720, but it flies right through here... Now I wonder what kind of CPU you are using? I have a i7-5600U CPU @ 2.60GHz here in my laptop, which has:
  > 
  >   $ lstopo --of console
  >   Machine (11GB)
  >     Package L#0 + L3 L#0 (4096KB)
  >       L2 L#0 (256KB) + L1d L#0 (32KB) + L1i L#0 (32KB) + Core L#0
  >         PU L#0 (P#0)
  >         PU L#1 (P#1)
  >       L2 L#1 (256KB) + L1d L#1 (32KB) + L1i L#1 (32KB) + Core L#1
  >         PU L#2 (P#2)
  >         PU L#3 (P#3)
  > 
  > 
  > The 1979 entries of attributes (each 12byte large) produce ~24KB of data, which fits nicely within my L1 cache. Maybe I'm just lucky and this is what hides this issue from me?
  
  Same debug output.
  
  AMD Phenom(tm) II X6 1100T Processor, 3.30 GHz
  Machine (16GB)
  
    Package L#0 + L3 L#0 (6144KB)
      L2 L#0 (512KB) + L1d L#0 (64KB) + L1i L#0 (64KB) + Core L#0 + PU L#0 (P#0)
      L2 L#1 (512KB) + L1d L#1 (64KB) + L1i L#1 (64KB) + Core L#1 + PU L#1 (P#1)
      L2 L#2 (512KB) + L1d L#2 (64KB) + L1i L#2 (64KB) + Core L#2 + PU L#2 (P#2)
      L2 L#3 (512KB) + L1d L#3 (64KB) + L1i L#3 (64KB) + Core L#3 + PU L#3 (P#3)
      L2 L#4 (512KB) + L1d L#4 (64KB) + L1i L#4 (64KB) + Core L#4 + PU L#4 (P#4)
      L2 L#5 (512KB) + L1d L#5 (64KB) + L1i L#5 (64KB) + Core L#5 + PU L#5 (P#5)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate, cullmann
Cc: anthonyfieroni, dhaumann, mwolff, cullmann, michaelh, kevinapavew, ngraham, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180323/8c6fd037/attachment.html>