D1231: Add Remote Access interface to KWayland

Roman Gilg noreply at phabricator.kde.org
Thu Mar 22 17:50:29 UTC 2018


romangg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:430
> +target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui KF5::WaylandClient KF5::WaylandServer)
> +add_test(kwayland-testRemoteAccess testRemoteAccess)
> +ecm_mark_as_test(testRemoteAccess)

`add_test(NAME kwayland-testRemoteAccess COMMAND testRemoteAccess)`

otherwise ctest doesn't find the test.

> remote_access_interface.cpp:206
> +        // clients don't necessarily bind outputs
> +        if (boundScreens.isEmpty())
> +            return;

Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180322/3a2d7e52/attachment.html>


More information about the Kde-frameworks-devel mailing list