D11569: Improve consistency of "Open With" UI
Anthony Fieroni
noreply at phabricator.kde.org
Thu Mar 22 14:25:52 UTC 2018
anthonyfieroni added inline comments.
INLINE COMMENTS
> kfileitemactions.cpp:654
> + // Always show the top app inline
> + QAction *act = d->createAppAction(offers.first(), menu);
> + menu->addAction(act);
Use offers.takeFirst(), it will get and remove.
> kfileitemactions.cpp:656
> + menu->addAction(act);
> + offers.removeFirst();
> +
Remove.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11569
To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180322/9eed49d6/attachment.html>
More information about the Kde-frameworks-devel
mailing list