D11452: sanitizer: Improve device listing
James Smith
noreply at phabricator.kde.org
Thu Mar 22 06:08:47 UTC 2018
smithjd added a comment.
In D11452#230590 <https://phabricator.kde.org/D11452#230590>, @michaelh wrote:
> In D11452#230387 <https://phabricator.kde.org/D11452#230387>, @smithjd wrote:
>
> > Could you please make your tab spacing conform to the style of the
> > codebase? This should also be fixed in baloodb.
>
If you browse your recently committed code in Diffusion, you'll notice that your linespaces can be copy and pasted. This doesn't match the current style where the tabs are spaces and the linespaces don't contain tab spaces and thus won't be copyable.
> baloo follows Kdelibs Coding Style <https://community.kde.org/Policies/Kdelibs_Coding_Style> that is 4 spaces per tab. Please specify the places this code (or baloodb) deviates from the rules.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11452
To: michaelh, #baloo, #frameworks
Cc: smithjd, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180322/cb0d1312/attachment.html>
More information about the Kde-frameworks-devel
mailing list