D11487: optimization of TextLineData::attribute

Jaime Torres Amate noreply at phabricator.kde.org
Tue Mar 20 08:26:02 UTC 2018


jtamate updated this revision to Diff 29975.
jtamate retitled this revision from "simple optimization of TextLineData::attribute" to "optimization of TextLineData::attribute".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  As m_attributesList is sorted, otherwise the original implementation will not work, 
  do a binary search looking for the lowest item that has offset >= pos.
  
  It gets even better, 0,32% of cpu in callgrind.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11487?vs=29925&id=29975

REVISION DETAIL
  https://phabricator.kde.org/D11487

AFFECTED FILES
  src/buffer/katetextline.h

To: jtamate, #frameworks, #kate
Cc: cullmann, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180320/391bc342/attachment.html>


More information about the Kde-frameworks-devel mailing list