D11287: Introduce baloodb CLI tool

Nathaniel Graham noreply at phabricator.kde.org
Mon Mar 19 13:58:45 UTC 2018


ngraham added inline comments.

INLINE COMMENTS

> michaelh wrote in main.cpp:161
> To point this out. I'm **not** the maintainer of baloo. Maybe better remove this?

I think you sort of are Baloo's de facto maintainer (which is a good thing, and you've earned the position)!

> main.cpp:65
> +
> +const auto commands = QVector<Command>{
> +    Command{

Any reason not to use a std::vector instead?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180319/7bea3c8e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list