D11287: Introduce baloodb CLI tool

Michael Heidelbach noreply at phabricator.kde.org
Mon Mar 19 13:54:04 UTC 2018


michaelh added inline comments.

INLINE COMMENTS

> mlaurent wrote in main.cpp:135
> very hard to read it.
> Could you split in several QString so it will more easy to check it's if ok :)

I had trouble myself :)

> main.cpp:161
> +                         i18n("(c) 2018, Michael Heidelbach"));
> +    aboutData.addAuthor(i18n("Michael Heidelbach"), i18n("Maintainer"), QStringLiteral("ottwolt at gmail.com"));
> +    KAboutData::setApplicationData(aboutData);

To point this out. I'm **not** the maintainer of baloo. Maybe better remove this?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11287

To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180319/e156648d/attachment.html>


More information about the Kde-frameworks-devel mailing list