D11484: Fix combobox breakage
Nathaniel Graham
noreply at phabricator.kde.org
Mon Mar 19 13:21:33 UTC 2018
ngraham created this revision.
ngraham added reviewers: broulik, Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.
REVISION SUMMARY
https://cgit.kde.org/plasma-framework.git/commit/?id=a21bc11fe11651f6d211489ebfc8435cef877194 erroneously added `renderType` properties to PlasmaComponents3 ComboBoxes, but QML ComboBoxes don't have this property, which broke Latte Dock's settings. This patch removes it.
BUG: 392026
TEST PLAN
- Deployed, added Latte Dock, ran Plasmashell with and without `PLASMA_USE_QT_SCALING=1`, and with and without a HiDPI scale factor
- Opened Latte Dock's settings window. In all cases, Latte Dock's settings window appeared normally and all comboboxes rendered properly
- Opened Folder View settings and verified that all ComboBoxes there looked and worked fine, too
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
fix-combobox-breakage (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11484
AFFECTED FILES
src/declarativeimports/plasmacomponents3/ComboBox.qml
src/declarativeimports/plasmastyle/ComboBoxStyle.qml
To: ngraham, broulik, #plasma
Cc: #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180319/461c8891/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list