D11331: add gaming_input devices and others to Battery

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Mar 19 09:56:02 UTC 2018


broulik added a comment.


  In D11331#226852 <https://phabricator.kde.org/D11331#226852>, @dollinger wrote:
  
  > I updated the diff, but unfortunately I'm not sure where to add that enum you @broulik mentioned since there is already one in `frontend\battery.h`:
  
  
  I think you can add an enum to `upower.h` and use it instead of the defines. I thought we already linked against UPower and could just use its header but we don't and I don't want to change that to avoid a dependency increase.
  
    enum UPowerBatteryType {
        UPowerBatteryTypeBattery,
        UPowerBatteryTypeUps,
        UPowerBatteryTypeMouse,
        ...
        UPowerBatteryTypeGamingInput
    };

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180319/73278923/attachment.html>


More information about the Kde-frameworks-devel mailing list