D11360: provide sample rate in kHz

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> widgetfactory.cpp:122-124
> +        if (prop == QLatin1String("duration")) {
>              valueString = form.formatDuration(value.toInt() * 1000);
> +        } else if (prop == QLatin1String("bitRate")) {

Please only one change per commit. I meant to use QLatin1String only for the new `sampleRate` prop.

I just fixed these 2 on master, please rebase this patch on top of it.

> widgetfactory.cpp:125
> +        } else if (prop == QLatin1String("bitRate")) {
> +            valueString = i18nc("@label bitrate (per second)", "%1/s", form.formatByteSize(value.toInt(), 0, KFormat::MetricBinaryDialect));
> +        } else if (prop == QLatin1String("sampleRate")) {

This should go in another commit.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11360

To: astippich, #frameworks, #baloo, elvisangelaccio
Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180318/0cdf2f5b/attachment.html>