D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

Martin Flöser noreply at phabricator.kde.org
Sat Mar 17 17:16:22 UTC 2018


graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma.
Restricted Application added a project: Frameworks.
graesslin requested review of this revision.

REVISION SUMMARY
  According to NETWM spec the client "wishing to change this list MUST send
  a _NET_WM_FULLSCREEN_MONITORS client message to the root window". This
  was not implemented at all, instead the property was updated. The
  property must be set by the window manager, or as the spec says:
  "The Window Manager MUST keep this list updated to reflect the current
  state of the window."
  
  In KWin (as the user of NETWinInfo) this was implemented correctly (see
  kwin, file netinfo.cpp method WinInfo::changeFullscreenMonitors).
  
  BUG: 391960

TEST PLAN
  New test case added which verifies the client/wm interplay,
  old and incorrect test case removed

REPOSITORY
  R278 KWindowSystem

BRANCH
  fix-fullscreen-monitors

REVISION DETAIL
  https://phabricator.kde.org/D11414

AFFECTED FILES
  autotests/netwininfotestclient.cpp
  autotests/netwininfotestwm.cpp
  src/platforms/xcb/netwm.cpp

To: graesslin, #frameworks, #kwin, #plasma
Cc: michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180317/1251d33d/attachment.html>


More information about the Kde-frameworks-devel mailing list