D11360: provide sample rate in kHz

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> widgetfactory.cpp:126
>              valueString = i18nc("@label bitrate (per second)", "%1/s", form.formatByteSize(value.toInt(), 1, KFormat::MetricBinaryDialect));
> +        } else if (prop == QStringLiteral("sampleRate")) {
> +            valueString = i18nc("@label samplerate in kilohertz", "%1 kHz", QLocale().toString(value.toDouble()/1000,'f', 1));

Please use `QLatin1String` for comparisons.

> widgetfactory.cpp:127
> +        } else if (prop == QStringLiteral("sampleRate")) {
> +            valueString = i18nc("@label samplerate in kilohertz", "%1 kHz", QLocale().toString(value.toDouble()/1000,'f', 1));
>          } else if (prop == QLatin1String("releaseYear")) {

This could show "48,0 kHz". Is that what we want?

Also, please add spaces before/after the division operator.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11360

To: astippich, #frameworks
Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180315/1e9b91f4/attachment.html>