D11365: also test for value types in taglibextractortest and fix errors
Alexander Stippich
noreply at phabricator.kde.org
Thu Mar 15 18:55:30 UTC 2018
astippich created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
astippich requested review of this revision.
REVISION SUMMARY
taglib tests never tested for the expected value type. add this to the tests and fix the resulting errors. also add some more metadata to the samplefiles
TEST PLAN
Thorough testing with baloo and all users of KFileMetaData
REPOSITORY
R286 KFileMetaData
BRANCH
taglib_test
REVISION DETAIL
https://phabricator.kde.org/D11365
AFFECTED FILES
autotests/samplefiles/test.flac
autotests/samplefiles/test.m4a
autotests/samplefiles/test.mp3
autotests/samplefiles/test.mpc
autotests/samplefiles/test.ogg
autotests/samplefiles/test.opus
autotests/taglibextractortest.cpp
src/extractors/taglibextractor.cpp
src/propertyinfo.cpp
To: astippich
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180315/cd526bf8/attachment.html>
More information about the Kde-frameworks-devel
mailing list