D10492: add 64px media icons for elisa
Alexander Stippich
noreply at phabricator.kde.org
Thu Mar 15 16:49:34 UTC 2018
astippich added a comment.
Sorry for being so late to the party, but I just found this while reading the Frameworks 5.44 release notes.
First of all, I am really grateful for the new icon. Actually, it would be really cool if we could also get a colorized version of a "media-artist" icon, since we are using a monochrome one there throughout Elisa :)
However, I think how the new icons are implemented here is problematic. You added icons with the same name as the monochrome ones, but the new ones look totally different. Depending on the icon size Elisa is requesting, we now get a different icon. This is also the reason why I created D10293 <https://phabricator.kde.org/D10293>.
Elisa is also using some color overlay effects, which now totally brake. I upgraded to Frameworks 5.44, and now Elisa looks like this:
F5755115: Screenshot_20180315_174420.png <https://phabricator.kde.org/F5755115>
F5755117: Screenshot_20180315_174431.png <https://phabricator.kde.org/F5755117>
The icon for the tracks view looks now out of place, and doesn't work with the color overlay.
Again, thanks for the icons, but I think they should be implemented with different names, so that we must add explicit support for them in Elisa. This may also effect other applications similarly.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D10492
To: andreask
Cc: astippich, ngraham, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180315/a668add1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list