D10918: taglibextractor: Refactor for better readability
Alexander Stippich
noreply at phabricator.kde.org
Thu Mar 15 16:35:13 UTC 2018
astippich accepted this revision.
astippich added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> michaelh wrote in taglibextractor.cpp:331
> I think it is. At this point only `ogg`, `flac` and `opus` should be left.
> Also I only refactored and didn't change the logic, unless I made a mistake that is.
you're right, it was the same way before and it already bugged me there ;)
but since this is a only refactoring, it's probably okay.
note that quite not all mimetypes are handled here compared with the mimetype list above (line 58)
REPOSITORY
R286 KFileMetaData
BRANCH
taglibextractor (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10918
To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180315/330e43ff/attachment.html>
More information about the Kde-frameworks-devel
mailing list