D10918: taglibextractor: Refactor for better readability

Alexander Stippich noreply at phabricator.kde.org
Thu Mar 15 07:04:04 UTC 2018


astippich added inline comments.

INLINE COMMENTS

> michaelh wrote in taglibextractor.cpp:157
> This is an example for what we're discussing. Why the join??? We might lose info, when the album artist contains a comma.

Yeah, I've seen that as well. Looks unnecessary, since we could also just directly add it to a stringlist. This is something I would like to change (at least for the taglibextractor)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180315/cb9b5069/attachment.html>


More information about the Kde-frameworks-devel mailing list