D11331: add gaming_input devices and others to Battery

Алексей Шилин noreply at phabricator.kde.org
Wed Mar 14 15:04:50 UTC 2018


aleksejshilin added inline comments.

INLINE COMMENTS

> upowerdevice.cpp:98
> +         */
> +        return (uptype != 0 && uptype != 1 && uptype != 4);
>      default:

So you're changing from 'whitelist' to 'blacklist' behavior here. What will happen when another UPower device type is added by the upstream?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180314/a72e7670/attachment.html>


More information about the Kde-frameworks-devel mailing list