D11278: [KateCompletionWidget] Create configuration interface on demand

Kevin Funk noreply at phabricator.kde.org
Tue Mar 13 11:07:41 UTC 2018


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  In D11278#224484 <https://phabricator.kde.org/D11278#224484>, @kfunk wrote:
  
  > Looks like you don't need the member at all? Otherwise late-init wouldn't work this way.
  >
  > `m_configWidget` seems only used in `showConfig()`. Let's remove the member altogether?
  
  
  Ah, disregard my comment.  If `showConfig()` is invoked multiple times then my approach would be slower.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11278

To: broulik, #ktexteditor, dhaumann, kfunk
Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180313/e3d3db5b/attachment.html>


More information about the Kde-frameworks-devel mailing list