D10918: taglibextractor: Refactor for better readability

Michael Heidelbach noreply at phabricator.kde.org
Tue Mar 13 09:51:37 UTC 2018


michaelh added a comment.


  In D10918#224424 <https://phabricator.kde.org/D10918#224424>, @astippich wrote:
  
  > Btw, I'm not opposed anymore for merging before D10803 <https://phabricator.kde.org/D10803>, as I need some more time to think about the value types and probably also need to extend the tests. I will adapt to the changes afterwards.
  
  
  Good! (I always thought it would be easier to apply your patch on top of this one). There is no need for you to commandeer this patch anymore. You could review it instead ;-)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10918

To: michaelh, mgallien, #baloo, #frameworks
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180313/717953e0/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list