D10694: epubextractor: Handle multiple subjects better

Matthieu Gallien noreply at phabricator.kde.org
Tue Mar 13 08:51:36 UTC 2018


mgallien added a comment.


  In D10694#224465 <https://phabricator.kde.org/D10694#224465>, @michaelh wrote:
  
  > In D10694#224440 <https://phabricator.kde.org/D10694#224440>, @mgallien wrote:
  >
  > > Could you please update your diff and we can land it ? This is a useful improvement.
  >
  >
  > 1. We can't land it yet. baloo searching breaks with this patch. baloo has be adapted first.
  
  
  I trust you on this one but on some property the taglib extractor is already doing multiple adds of the same property. It means Baloo is already storing lists.
  I can help you but have not much time as usual.
  
  > 1. I don't know what to update. Please tell me once more what you want me to change.
  
  You can have a look at the taglib extractor. There are multiple examples of for loops adding multiple times the same property.
  
  > For this change concerted actions are needed. Let's discuss general questions here:  T8196 <https://phabricator.kde.org/T8196>
  
  Thanks, this is a good idea.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180313/5ac0a06c/attachment.html>


More information about the Kde-frameworks-devel mailing list