D10694: epubextractor: Handle multiple subjects better

Matthieu Gallien noreply at phabricator.kde.org
Tue Mar 13 07:26:21 UTC 2018


mgallien added a comment.


  In D10694#222674 <https://phabricator.kde.org/D10694#222674>, @michaelh wrote:
  
  > @mgallien: I think we have a beautiful misunderstanding here :-)
  >
  > In D10694#221719 <https://phabricator.kde.org/D10694#221719>, @michaelh wrote:
  >
  > > This is bad! ...
  >
  >
  > I was referring to baloo inablility to  handle string lists and not to this diff.
  >
  > In D10694#221734 <https://phabricator.kde.org/D10694#221734>, @mgallien wrote:
  >
  > > I believe this is quite the opposite. ...
  >
  >
  > I took your answer the wrong way completely. Let's rewind our conversation a little
  
  
  No problem from side. In fact this is quite the opposite given you made me better understand all this code. I have now to fix Elisa code to handle lists where I was expecting a single string.
  
  Could you please update your diff and we can land it ? This is a useful improvement.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180313/82b96a01/attachment.html>


More information about the Kde-frameworks-devel mailing list