D10078: Add separate lib KF5::DBusRunner
David Edmundson
noreply at phabricator.kde.org
Tue Mar 13 00:49:10 UTC 2018
davidedmundson updated this revision to Diff 29364.
davidedmundson added a comment.
Rewritten with the second class I suggested.
Not trying to comandeer your work, if you think it was better before, go for that.
IMHO it's nice and OO now with the submit/cancel methods being with the data.
It allows a client to:
- easily respond in a sync fashion, with one less line than before
- easily keep track of the latest request, without having to track signals
- optionally respond to every request in any arbitrary order (if using threads)
Context needs some docs, but I thought I'd let you comment first.
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10078?vs=29362&id=29364
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10078
AFFECTED FILES
KF5DBusRunnerConfig.cmake.in
autotests/CMakeLists.txt
autotests/testremoterunner.cpp
autotests/testremoterunner.h
src/CMakeLists.txt
src/dbusrunner/CMakeLists.txt
src/dbusrunner/abstractrunner.cpp
src/dbusrunner/abstractrunner.h
src/dbusrunner/abstractrunner_p.cpp
src/dbusrunner/abstractrunner_p.h
src/dbusrunner/action.h
src/dbusrunner/dbusadaptor.cpp
src/dbusrunner/dbusadaptor_p.h
src/dbusrunner/querymatch.h
src/querymatch.h
To: davidedmundson, broulik, kossebau
Cc: michaelh, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180313/0b4887f6/attachment.html>
More information about the Kde-frameworks-devel
mailing list