D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Kai's right. The patch doesn't work as indented. You're (accidentally) just always enabling Text.QtRendering
  
  If we take your code in Label and change it to the color line
  
    color: QtQuickControlsPrivate.Settings.isMobile ||Window.devicePixelRatio % 1 !== 0 ? "red" : "blue"
  
  It should change depending on QT_SCREEN_SCALE_FACTORS. Yet I always get red.
  It does imply the code in QQC2-desktop-style is wrong too.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11244

To: ngraham, #plasma, davidedmundson
Cc: broulik, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180312/d111e4aa/attachment.html>