D11173: Actually vote when clicking stars in the details view

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Fri Mar 9 09:34:59 UTC 2018


leinir created this revision.
leinir added reviewers: KNewStuff, Frameworks, sitter.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
leinir requested review of this revision.

REVISION SUMMARY
  This connects up the ratings widget with the engine, using the same vote logic found in the list delegate.
  
  This code has been missing for what i can only assume is a very long time. Nobody will have known, because the ratings widget updates its view immediately and only then sends the request off for voting.
  
  BUG: 391112

TEST PLAN
  Without patch: Only view updates when clicking stars in the item details view
  With patch: Request is sent to the newstuff engine to perform a vote

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D11173

AFFECTED FILES
  src/ui/itemsviewdelegate.cpp

To: leinir, #knewstuff, #frameworks, sitter
Cc: michaelh, ZrenBot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180309/d51680fd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list