D11129: Mark kpackage_install_package undeprecated for plasma_install_package

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Mar 8 17:23:06 UTC 2018


apol added inline comments.

INLINE COMMENTS

> KF5PackageMacros.cmake:27
> +   # allow plasma_install_package to disable the warning until it is ported away from this
> +   if (NOT ARGV4 STREQUAL NO_DEPRECATED_WARNING)
> +      message(AUTHOR_WARNING "Deprecated: use kpackage_install_bundled_package")

How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)?

This way it's only shown on projects that are actually depending on the new version. And if they are well then that's fine to have the warning.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11129

To: kossebau, mart, apol
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180308/7ab90985/attachment.html>


More information about the Kde-frameworks-devel mailing list