D10712: balooctl monitor: Resume to wait for service
Michael Heidelbach
noreply at phabricator.kde.org
Wed Mar 7 11:03:35 UTC 2018
michaelh added inline comments.
INLINE COMMENTS
> mwolff wrote in monitorcommand.cpp:45
> just make it i18n("Baloo died"), though I personally think that message should be improved - maybe "Baloo became unavailable" ?
>
> also, call `balooIsNotAvailable()` from the slot here, that way you safe one connection. Or just move the m_err output to the `balooIsNotAvailable` slot.
Can be removed completely.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D10712
To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff
Cc: mwolff, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180307/acc6bc55/attachment.html>
More information about the Kde-frameworks-devel
mailing list