D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Mar 7 07:58:28 UTC 2018


broulik created this revision.
broulik added reviewers: Frameworks, hein.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  `KProtocolInfoFactory::findProtocol` clears its cache when requested an unknown protocol in the hope of finding it due to an outdated cache. However, when the cache had just been created, there's no point in clearing and recreating it right away

TEST PLAN
  Mitigates the effects of D9094 <https://phabricator.kde.org/D9094> somewhat (takes 4.5ms instead of 9ms on startup for me now)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11107

AFFECTED FILES
  src/core/kprotocolinfofactory.cpp

To: broulik, #frameworks, hein
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180307/ca09e2fd/attachment.html>


More information about the Kde-frameworks-devel mailing list