D11099: Fix compilation on Android

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Mar 7 00:55:07 UTC 2018


apol added a comment.


  I actually hit this issue this week (you can see build.kde.org failing earlier this week:
  https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/
  
  I fixed it by using android-21 as the sdk version, maybe it's a more acceptable compromise?
  I'm not sure what we are compromising over though.

INLINE COMMENTS

> kshareddatacache_p.h:405
>          if (timeoutsSupported) {
> +#ifdef KSDC_TIMEOUTS_SUPPORTED
>              tempLock = QSharedPointer<KSDCLock>(new semaphoreTimedLock(tempSemaphore));

There's a weird whitespace here.

> kshareddatacache_p.h:406
> +#ifdef KSDC_TIMEOUTS_SUPPORTED
>              tempLock = QSharedPointer<KSDCLock>(new semaphoreTimedLock(tempSemaphore));
> +#endif

#else Q_UNREACHABLE?
Or what happens?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D11099

To: vkrause, #frameworks
Cc: apol, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180307/2c4dc9f2/attachment.html>


More information about the Kde-frameworks-devel mailing list