D11044: Don't try to find an icon for an empty url
David Faure
noreply at phabricator.kde.org
Mon Mar 5 10:13:50 UTC 2018
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Wait, who's calling KIO::iconNameForUrl() with an empty URL? This should be an assert or an early-return at the top of that method, not nested into one specific if(). Even the very beginning, db.mimeTypeForUrl(url), makes no sense for an empty URL.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11044
To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180305/57d3dc7a/attachment.html>
More information about the Kde-frameworks-devel
mailing list