D10822: Store temporary authorization status in IdleSlave

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> idleslave.cpp:70
>          deleteLater();
> -    } else if (cmd != MSG_SLAVE_STATUS) {
> +    } else if (cmd != MSG_SLAVE_STATUS_V2) {
>          qCritical() << "Unexpected data from KIO slave.";

This could be made more runtime compatible by not rejecting MSG_SLAVE_STATUS completely, and handling it below (e.g. with a test on cmd at the right place, to still share the local variables).

(That's what I meant by "support both here").

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10822

To: chinmoyr, dfaure
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180304/eb3717ca/attachment.html>