D10993: Fix protocol selection in KUrlNavigator

Алексей Шилин noreply at phabricator.kde.org
Sun Mar 4 10:18:05 UTC 2018


aleksejshilin added inline comments.

INLINE COMMENTS

> dfaure wrote in kurlnavigator.cpp:349
> Well, OK, it's not that it's *incorrect* for file:, it just seems unnecessary to make that method call. So given that we have an if() already, why not only do it in the else?

> Well, OK, it's not that it's *incorrect* for file:, it just seems unnecessary to make that method call.

Ah, I misunderstood what you meant.

> So given that we have an if() already, why not only do it in the else?

Done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10993

To: aleksejshilin, #frameworks, dfaure
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180304/47ded7a0/attachment.html>


More information about the Kde-frameworks-devel mailing list