D11011: Do not assume layout of msghdr and iovec structure

David Faure noreply at phabricator.kde.org
Sun Mar 4 09:27:16 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> sharefd_p.h:85
> +        msg.msg_iovlen = 1;
> +        msg.msg_control = &cmsg_buf;
> +        msg.msg_controllen = sizeof cmsg_buf;

Looks good, it's just a bit inconsistent that iov_base points to io_buf (without &) and msg_control points to &cmsg_buf (with &), both members being char [N]. It turns out that both work, but why not use the same syntax both times?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11011

To: chinmoyr, dfaure, awilcox
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180304/5e1cfaee/attachment.html>


More information about the Kde-frameworks-devel mailing list