D10993: Fix protocol selection in KUrlNavigator

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> aleksejshilin wrote in kurlnavigator.cpp:349
> > Is this in order to get smb:// instead of smb: ?
> 
> Yes.
> 
> > It looks correct, but not for "file",
> 
> Why not? If I read RFC 8089 correctly, for host rule it references RFC 3986 which allows it to be empty, i.e. an empty authority is valid.
> 
> > And I could add a comment like "we want smb:// or ftp://, not just smb: or ftp:".
> 
> Makes sense, indeed. Will do shortly.

Well, OK, it's not that it's *incorrect* for file:, it just seems unnecessary to make that method call. So given that we have an if() already, why not only do it in the else?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10993

To: aleksejshilin, #frameworks, dfaure
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180304/0ddcf126/attachment.html>