D10993: Fix protocol selection in KUrlNavigator

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks for the fix. I have one small suggestion.

INLINE COMMENTS

> kurlnavigator.cpp:349
>      url.setScheme(protocol);
> -    url.setPath((protocol == QLatin1String("file")) ? QStringLiteral("/") : QStringLiteral("//"));
> +    url.setAuthority(QStringLiteral(""));
> +    if (protocol == QLatin1String("file")) {

Is this in order to get smb:// instead of smb: ? It looks correct, but not for "file", how about moving that to an else{} branch of the if below? And I could add a comment like "we want smb:// or ftp://, not just smb: or ftp:".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10993

To: aleksejshilin, #frameworks, dfaure
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180303/6148fdd0/attachment-0001.html>