D10273: Create proper SocketAddress

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> chinmoyr wrote in fdsender.cpp:24
> The idea was to use std c++ and avoid qt throughout the class because the code will be executed with elevated privileges.

In that case I don't understand why SocketAddress takes a QByteArray and not a std::string.... Because ossi suggested it to unify the API and avoid one conversion to std::string in fdereceiver? But then we have two contradictory goals, we need to decide whether we use Qt or not in fdsender and therefore in SocketAddress. Since one is not supposed to use Qt API without a QCoreApplication instance, and since it's not recommented to run Qt code as root, I think your original idea made sense, no Qt in fdsender nor in SocketAddress.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10273

To: chinmoyr, #frameworks, dfaure
Cc: ossi, thiago, dfaure, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180303/0ca68fbe/attachment.html>